From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7337 invoked by alias); 7 Apr 2010 19:56:14 -0000 Received: (qmail 7327 invoked by uid 22791); 7 Apr 2010 19:56:13 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 19:56:08 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o37JtxY6031279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Apr 2010 15:55:59 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o37JtwJB005843; Wed, 7 Apr 2010 15:55:59 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o37Jtvgv029961; Wed, 7 Apr 2010 15:55:58 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C149C379851; Wed, 7 Apr 2010 13:55:57 -0600 (MDT) From: Tom Tromey To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [PATCH/RFC] Include value of default-collect in breakpoint/tracepoint list References: <4BBA7264.5060109@codesourcery.com> Reply-To: tromey@redhat.com Date: Wed, 07 Apr 2010 19:56:00 -0000 In-Reply-To: <4BBA7264.5060109@codesourcery.com> (Stan Shebs's message of "Mon, 05 Apr 2010 16:29:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00154.txt.bz2 >>>>> "Stan" == Stan Shebs writes: Stan> 2010-04-05 Stan Shebs Stan> * breakpoint.c (default_collect_info): New function. Stan> (breakpoints_info): Call it. Stan> (maintenance_info_breakpoints): Ditto. Stan> (tracepoints_info): Ditto. Stan> + static void default_collect_info (void); Stan> + /* Display the value of default-collect in a way that is generally Stan> + compatible with the breakpoint list. */ Stan> + Stan> + void Stan> + default_collect_info (void) It is mildly weird for the declaration to have 'static' but not the definition. Also, I think the preferred style nowadays is to order functions so that we don't need forward declarations (when possible). FWIW, and since you asked, I think the idea behind the patch seems fine. Tom