From: Phil Muldoon <pmuldoon@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch][python] Auto-load gdb.command and gdb.function modules
Date: Thu, 04 Aug 2011 16:53:00 -0000 [thread overview]
Message-ID: <m3ty9xgluh.fsf@redhat.com> (raw)
This patch enables module auto-importing for the gdb.command and
gdb.function name-spaces. Any Python file (which is not __init__.py)
located in {data-directory}/gdb/python/command and
{data-directory}/gdb/python/function is now automatically imported, and
available immediately upon GDB start.
Tested on X86-64 with no regressions.
OK?
Cheers,
Phil
2011-08-04 Phil Muldoon <pmuldoon@redhat.com>
* python/lib/gdb/command/pretty_printers.py: Self-register
command.
* python/python.c (finish_python_initialization): Use os.path.join.
* python/lib/gdb/__init__.py: Add automatic module loading code.
Remove explicit pretty-printers.py import and registration
function.
2011-08-04 Phil Muldoon <pmuldoon@redhat.com>
* gdb.texinfo (Python): Document command and function module
auto-loading on start-up.
--
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 35fa075..9a0c8db 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -20845,6 +20845,12 @@ This directory, known as the @dfn{python directory},
is automatically added to the Python Search Path in order to allow
the Python interpreter to locate all scripts installed at this location.
+Additionally, @value{GDBN} commands and convenience functions which
+are written in Python and are located in the
+@file{@var{data-directory}/python/gdb/command} or
+@file{@var{data-directory}/python/gdb/function} directories are
+automatically imported when @value{GDBN} starts.
+
@menu
* Python Commands:: Accessing Python from @value{GDBN}.
* Python API:: Accessing @value{GDBN} from Python.
diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py
index 43975c2..38e58fb 100644
--- a/gdb/python/lib/gdb/__init__.py
+++ b/gdb/python/lib/gdb/__init__.py
@@ -13,6 +13,27 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-import gdb.command.pretty_printers
+# Auto load all functions/commands.
-gdb.command.pretty_printers.register_pretty_printer_commands()
+# Modules to auto-load, and the paths where those modules exist.
+
+module_dict = {\
+'gdb.function': os.path.join(gdb.PYTHONDIR, 'gdb', 'function'),\
+'gdb.command': os.path.join(gdb.PYTHONDIR, 'gdb', 'command')\
+}
+
+# Iterate the dictionary, collating the Python files in each module
+# path. Construct the module name, and import.
+
+for module, location in module_dict.iteritems():
+ if os.path.exists(location):
+ py_files = filter(lambda x: x.endswith('.py') and x != '__init__.py',\
+ os.listdir(location))
+
+ for py_file in py_files:
+ py_file = py_file.rstrip('.py')
+ py_file = module + '.' + py_file
+ try:
+ exec('import ' + py_file)
+ except:
+ print 'Error importing: ', py_file
diff --git a/gdb/python/lib/gdb/command/pretty_printers.py b/gdb/python/lib/gdb/command/pretty_printers.py
index 86923d7..00aa390 100644
--- a/gdb/python/lib/gdb/command/pretty_printers.py
+++ b/gdb/python/lib/gdb/command/pretty_printers.py
@@ -368,3 +368,5 @@ def register_pretty_printer_commands():
InfoPrettyPrinter()
EnablePrettyPrinter()
DisablePrettyPrinter()
+
+register_pretty_printer_commands()
diff --git a/gdb/python/python.c b/gdb/python/python.c
index 16c0a6e..03edce9 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1302,13 +1302,13 @@ def GdbSetPythonDirectory (dir):\n\
sys.path.insert (0, gdb.PYTHONDIR)\n\
\n\
# Tell python where to find submodules of gdb.\n\
- gdb.__path__ = [gdb.PYTHONDIR + '/gdb']\n\
+ gdb.__path__ = [os.path.join (gdb.PYTHONDIR, 'gdb')]\n\
\n\
# The gdb module is implemented in C rather than in Python. As a result,\n\
# the associated __init.py__ script is not not executed by default when\n\
# the gdb module gets imported. Execute that script manually if it\n\
# exists.\n\
- ipy = gdb.PYTHONDIR + '/gdb/__init__.py'\n\
+ ipy = os.path.join (gdb.PYTHONDIR, 'gdb', '__init__.py')\n\
if os.path.exists (ipy):\n\
execfile (ipy)\n\
\n\
next reply other threads:[~2011-08-04 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 16:53 Phil Muldoon [this message]
2011-08-04 17:12 ` Tom Tromey
2011-08-04 18:31 ` Phil Muldoon
2011-08-04 18:59 ` Tom Tromey
2011-08-08 11:58 ` Phil Muldoon
2011-08-08 14:10 ` Eli Zaretskii
2011-08-09 12:46 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ty9xgluh.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox