Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch][python] Auto-load gdb.command and gdb.function modules
Date: Thu, 04 Aug 2011 18:59:00 -0000	[thread overview]
Message-ID: <m3hb5xype6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3oc05gha1.fsf@redhat.com> (Phil Muldoon's message of "Thu, 04	Aug 2011 19:31:34 +0100")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> +       py_file = py_file.rstrip('.py')

The argument to rstrip is a set of characters; I think this will do the
wrong thing for, e.g., "p.py".
You can just use py_file[:-3] instead.
The code bits are ok with that change.

Tom


  reply	other threads:[~2011-08-04 18:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 16:53 Phil Muldoon
2011-08-04 17:12 ` Tom Tromey
2011-08-04 18:31   ` Phil Muldoon
2011-08-04 18:59     ` Tom Tromey [this message]
2011-08-08 11:58       ` Phil Muldoon
2011-08-08 14:10         ` Eli Zaretskii
2011-08-09 12:46           ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hb5xype6.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox