From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org, cmtice@google.com
Subject: Re: [patch] handle nested exceptions
Date: Thu, 15 Dec 2011 15:04:00 -0000 [thread overview]
Message-ID: <m3ty516fvj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20111214220625.31BFB2461AD@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 14 Dec 2011 14:06:24 -0800 (PST)")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> I will check this in in a few days if there are no objections.
Doug> 2011-12-14 Doug Evans <dje@google.com>
Doug> * exceptions.c (catcher_list_size): New function.
Doug> (last_message): Delete.
Doug> (exception_messages, exception_messages_size): New static globals.
Doug> (throw_it): Use exception_messages array to handle nested calls.
It seems good to me.
It was a little hard to understand why this was the right approach.
Actually I am not 100% sure I have convinced myself.
I think a comment explaining the motivating scenario would help.
Tom
next prev parent reply other threads:[~2011-12-15 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 23:21 Doug Evans
2011-12-15 15:04 ` Tom Tromey [this message]
2011-12-15 18:45 ` Doug Evans
2011-12-15 21:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ty516fvj.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=cmtice@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox