From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20425 invoked by alias); 15 Dec 2011 14:59:04 -0000 Received: (qmail 20374 invoked by uid 22791); 15 Dec 2011 14:59:02 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Dec 2011 14:58:43 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBFEwgBI026006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 15 Dec 2011 09:58:42 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pBFEwfaX032241; Thu, 15 Dec 2011 09:58:41 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pBFEweKv016547; Thu, 15 Dec 2011 09:58:40 -0500 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org, cmtice@google.com Subject: Re: [patch] handle nested exceptions References: <20111214220625.31BFB2461AD@ruffy.mtv.corp.google.com> Date: Thu, 15 Dec 2011 15:04:00 -0000 In-Reply-To: <20111214220625.31BFB2461AD@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 14 Dec 2011 14:06:24 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00501.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> I will check this in in a few days if there are no objections. Doug> 2011-12-14 Doug Evans Doug> * exceptions.c (catcher_list_size): New function. Doug> (last_message): Delete. Doug> (exception_messages, exception_messages_size): New static globals. Doug> (throw_it): Use exception_messages array to handle nested calls. It seems good to me. It was a little hard to understand why this was the right approach. Actually I am not 100% sure I have convinced myself. I think a comment explaining the motivating scenario would help. Tom