Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Test cases nsusing.exp and nsrecurs.exp
Date: Wed, 27 Jan 2010 23:02:00 -0000	[thread overview]
Message-ID: <m3sk9rb198.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B609E5F.9060008@redhat.com> (Sami Wagiaalla's message of "Wed, 	27 Jan 2010 15:13:19 -0500")

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> This patch contains the remainder of the nsusing.exp and nsrecurs.exp
Sami> test cases. Committing entire test cases makes it easier to manage
Sami> patches and avoids creation of unneeded conflicts. I have patches for
Sami> all the kfails.

I think it is more usual to submit the patches as a series, with the
test cases being one part, or to split them up.  I don't really have a
problem with it this time, since I know you'll be sending them soon, but
next time this would be better.

What I do is make a private branch in git and make each commit a
separate submittable patch; then I rebase and/or edit the history as
needed.

Sami> +gdb_test "print _a" "No symbol \"_a\" in current context." "Print _a without import"

There are a few over-long lines like this.  Break them up like:

gdb_test "print _a" "No symbol \"_a\" in current context." \
    "Print _a without import"

Ok with that change.

Tom


  reply	other threads:[~2010-01-27 23:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 20:10 Sami Wagiaalla
2010-01-27 23:02 ` Tom Tromey [this message]
2010-01-28 18:01   ` Sami Wagiaalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sk9rb198.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox