From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2528 invoked by alias); 27 Jan 2010 23:02:06 -0000 Received: (qmail 2337 invoked by uid 22791); 27 Jan 2010 23:02:05 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Jan 2010 23:02:00 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0RN1wYt025750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Jan 2010 18:01:58 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0RN1vV5014164; Wed, 27 Jan 2010 18:01:58 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0RN1up7003794; Wed, 27 Jan 2010 18:01:57 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6B8BE379315; Wed, 27 Jan 2010 16:01:56 -0700 (MST) From: Tom Tromey To: Sami Wagiaalla Cc: GDB Patches Subject: Re: [patch] Test cases nsusing.exp and nsrecurs.exp References: <4B609E5F.9060008@redhat.com> Reply-To: tromey@redhat.com Date: Wed, 27 Jan 2010 23:02:00 -0000 In-Reply-To: <4B609E5F.9060008@redhat.com> (Sami Wagiaalla's message of "Wed, 27 Jan 2010 15:13:19 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00600.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> This patch contains the remainder of the nsusing.exp and nsrecurs.exp Sami> test cases. Committing entire test cases makes it easier to manage Sami> patches and avoids creation of unneeded conflicts. I have patches for Sami> all the kfails. I think it is more usual to submit the patches as a series, with the test cases being one part, or to split them up. I don't really have a problem with it this time, since I know you'll be sending them soon, but next time this would be better. What I do is make a private branch in git and make each commit a separate submittable patch; then I rebase and/or edit the history as needed. Sami> +gdb_test "print _a" "No symbol \"_a\" in current context." "Print _a without import" There are a few over-long lines like this. Break them up like: gdb_test "print _a" "No symbol \"_a\" in current context." \ "Print _a without import" Ok with that change. Tom