From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] i8n replacement/capitalize/full sentences on Python error messages.
Date: Tue, 13 Apr 2010 23:30:00 -0000 [thread overview]
Message-ID: <m3sk6z6id2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BC4DABE.9050704@redhat.com> (Phil Muldoon's message of "Tue, 13 Apr 2010 21:57:34 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> During a recent review we caught some messages that were not written
Phil> enclosed with _() and therefore would not allow for
Phil> internationalization. I decided to audit the rest of the code, and
Phil> found a few more.
Thanks!
Phil> This patch converts those error strings. Additionally, in some
Phil> cases, I added capitalization and punctuation. This patch is
Phil> largely mechanical and obvious, but I did not commit under the
Phil> obvious rule as it pretty much touches every file in the Python
Phil> section.
Phil> OK?
I skimmed it and it seems fine.
Please check this in.
Tom
prev parent reply other threads:[~2010-04-13 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 20:57 Phil Muldoon
2010-04-13 23:30 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sk6z6id2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox