From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30240 invoked by alias); 13 Apr 2010 23:30:31 -0000 Received: (qmail 30231 invoked by uid 22791); 13 Apr 2010 23:30:30 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Apr 2010 23:30:26 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3DNUMAq032689 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Apr 2010 19:30:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3DNUIop005799; Tue, 13 Apr 2010 19:30:21 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3DNUHbu010653; Tue, 13 Apr 2010 19:30:18 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 90C1A378887; Tue, 13 Apr 2010 17:30:17 -0600 (MDT) From: Tom Tromey To: Phil Muldoon Cc: gdb-patches ml Subject: Re: [python][patch] i8n replacement/capitalize/full sentences on Python error messages. References: <4BC4DABE.9050704@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 13 Apr 2010 23:30:00 -0000 In-Reply-To: <4BC4DABE.9050704@redhat.com> (Phil Muldoon's message of "Tue, 13 Apr 2010 21:57:34 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00437.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> During a recent review we caught some messages that were not written Phil> enclosed with _() and therefore would not allow for Phil> internationalization. I decided to audit the rest of the code, and Phil> found a few more. Thanks! Phil> This patch converts those error strings. Additionally, in some Phil> cases, I added capitalization and punctuation. This patch is Phil> largely mechanical and obvious, but I did not commit under the Phil> obvious rule as it pretty much touches every file in the Python Phil> section. Phil> OK? I skimmed it and it seems fine. Please check this in. Tom