Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] Fix PR/12183
Date: Mon, 21 Mar 2011 16:13:00 -0000	[thread overview]
Message-ID: <m3sjugv5k3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3hbawr6ax.fsf@redhat.com> (Phil Muldoon's message of "Mon, 21	Mar 2011 12:45:10 +0000")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> This patch fixes PR python/12183.  In this case GDB was printing a
Phil> stack trace for a gdb.GdbError.  This is incorrect, GdbErrors
Phil> should not produce a stack trace.  This fix is largely a duplicate
Phil> of the code already in py-cmd.

Phil> OK?

Looks good, just one nit.

Phil> +  if (! result)

We decided not to put a space after '! 'here.

Phil> +      if (! PyErr_GivenExceptionMatches (ptype, gdbpy_gdberror_exc)

And likewise.

Ok with this fixed.

Tom


  reply	other threads:[~2011-03-21 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 14:47 Phil Muldoon
2011-03-21 16:13 ` Tom Tromey [this message]
2011-03-22 10:25   ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sjugv5k3.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox