From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79847-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5758 invoked by alias); 21 Mar 2011 15:47:52 -0000
Received: (qmail 5655 invoked by uid 22791); 21 Mar 2011 15:47:50 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Mar 2011 15:47:43 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2LFlfCH009188	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 21 Mar 2011 11:47:42 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2LFlfvo007193;	Mon, 21 Mar 2011 11:47:41 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2LFlee1029260;	Mon, 21 Mar 2011 11:47:41 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id A989F378491; Mon, 21 Mar 2011 09:47:40 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] Fix PR/12183
References: <m3hbawr6ax.fsf@redhat.com>
Date: Mon, 21 Mar 2011 16:13:00 -0000
In-Reply-To: <m3hbawr6ax.fsf@redhat.com> (Phil Muldoon's message of "Mon, 21	Mar 2011 12:45:10 +0000")
Message-ID: <m3sjugv5k3.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00960.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> This patch fixes PR python/12183.  In this case GDB was printing a
Phil> stack trace for a gdb.GdbError.  This is incorrect, GdbErrors
Phil> should not produce a stack trace.  This fix is largely a duplicate
Phil> of the code already in py-cmd.

Phil> OK?

Looks good, just one nit.

Phil> +  if (! result)

We decided not to put a space after '! 'here.

Phil> +      if (! PyErr_GivenExceptionMatches (ptype, gdbpy_gdberror_exc)

And likewise.

Ok with this fixed.

Tom