Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] gdb.mi/mi2-console.exp: fix racy test (PR testsuite/12649)
@ 2011-06-22 11:26 Marek Polacek
  2011-06-22 19:39 ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Polacek @ 2011-06-22 11:26 UTC (permalink / raw)
  To: gdb-patches

Use mi_gdb_test in place of gdb_test_multiple.  Note, that I had to 
add "()?" around the first \r\n.  The reason is that mi_gdb_test
appends \r\n itself, but the "*running,thread-id=all" part is not mandatory.

Tested with both read{,1}.  OK to apply?

2011-06-22  Marek Polacek  <mpolacek@redhat.com>

        * gdb.mi/mi2-console.exp: Replace gdb_test_multiple with mi_gdb_test.

--- gdb/gdb/testsuite/gdb.mi/mi2-console.exp.mp 2011-06-22 12:58:23.697574353 +0200
+++ gdb/gdb/testsuite/gdb.mi/mi2-console.exp    2011-06-22 13:16:48.577665717 +0200
@@ -48,11 +48,8 @@ if  { [gdb_compile "${srcdir}/${subdir}/
 mi_run_to_main
 
 # Next over the hello() call which will produce lots of output
-gdb_test_multiple "220-exec-next" "Started step over hello" {
-    -re "220\\^running\r\n(\\*running,thread-id=\"all\"\r\n)?$mi_gdb_prompt" {
-       pass "Started step over hello"
-    }
-}
+mi_gdb_test "220-exec-next" "220\\^running(\r\n)?(\\*running,thread-id=\"all\")?" \
+       "Started step over hello"
 
 if { ![target_info exists gdb,noinferiorio] } { 
     gdb_expect {
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb.mi/mi2-console.exp: fix racy test (PR testsuite/12649)
  2011-06-22 11:26 [PATCH] gdb.mi/mi2-console.exp: fix racy test (PR testsuite/12649) Marek Polacek
@ 2011-06-22 19:39 ` Tom Tromey
  2011-06-23  9:41   ` Marek Polacek
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2011-06-22 19:39 UTC (permalink / raw)
  To: Marek Polacek; +Cc: gdb-patches

>>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:

Marek> 2011-06-22  Marek Polacek  <mpolacek@redhat.com>
Marek>         * gdb.mi/mi2-console.exp: Replace gdb_test_multiple with mi_gdb_test.

Ok.

Tom


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb.mi/mi2-console.exp: fix racy test (PR testsuite/12649)
  2011-06-22 19:39 ` Tom Tromey
@ 2011-06-23  9:41   ` Marek Polacek
  0 siblings, 0 replies; 3+ messages in thread
From: Marek Polacek @ 2011-06-23  9:41 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On 06/22/2011 09:39 PM, Tom Tromey wrote:
> Ok.

Thanks, checked in:
http://sourceware.org/ml/gdb-cvs/2011-06/msg00135.html

	Marek


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-06-23  9:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-22 11:26 [PATCH] gdb.mi/mi2-console.exp: fix racy test (PR testsuite/12649) Marek Polacek
2011-06-22 19:39 ` Tom Tromey
2011-06-23  9:41   ` Marek Polacek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox