From: Phil Muldoon <pmuldoon@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, eli@gnu.org, gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR python/12656 (API for special blocks)
Date: Mon, 17 Oct 2011 12:49:00 -0000 [thread overview]
Message-ID: <m3sjmr7rvm.fsf@redhat.com> (raw)
In-Reply-To: <E1RFlAt-0004KD-FT@fencepost.gnu.org> (Eli Zaretskii's message of "Mon, 17 Oct 2011 07:16:07 -0400")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Phil Muldoon <pmuldoon@redhat.com>
>> Cc: gdb-patches@sourceware.org
>> Date: Mon, 17 Oct 2011 11:31:06 +0100
>>
>> doco ping
>
> Sorry, missed the original posting.
>
> I have a couple of comments:
>
>> +@defvar Block.is_global ()
>> +@code{True} if the @code{gdb.Block} object is the global block
>> +for the inferior, @code{False} if not. This attribute is not
>> +writable.
>
> If this is an attribute, why do you use "()" on the @defvar line?
They used to be methods in a previous posting, I just forgot to remove
the "()"'s when I converted them to attributes. Fixed locally.
> Also, what do you mean by "the global block for the inferior"? why
> "the" global block? There could be more than one such block, right?
Oops, fixed and for static too.
> And the same goes for the static attribute.
Is this ok, or do you want me to re-post the patch?
Cheers,
Phil
next prev parent reply other threads:[~2011-10-17 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 17:02 Phil Muldoon
2011-10-07 20:41 ` Tom Tromey
2011-10-10 9:34 ` Phil Muldoon
2011-10-10 18:27 ` Tom Tromey
2011-10-11 16:00 ` Phil Muldoon
[not found] ` <09787EF419216C41A903FD14EE5506DD030BEC56DF@AUSX7MCPC103.AMER.DELL.COM>
2011-10-11 16:06 ` Paul Koning
2011-10-11 18:32 ` Phil Muldoon
2011-10-11 17:30 ` Tom Tromey
2011-10-17 10:59 ` Phil Muldoon
2011-10-17 11:57 ` Eli Zaretskii
2011-10-17 12:49 ` Phil Muldoon [this message]
2011-10-17 15:07 ` Eli Zaretskii
2011-10-20 12:58 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sjmr7rvm.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=eli@gnu.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox