From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84458-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29417 invoked by alias); 17 Oct 2011 11:57:37 -0000
Received: (qmail 29404 invoked by uid 22791); 17 Oct 2011 11:57:36 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 11:57:20 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9HBvJWN025770	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 17 Oct 2011 07:57:19 -0400
Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9HBvHto003544;	Mon, 17 Oct 2011 07:57:17 -0400
From: Phil Muldoon <pmuldoon@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, eli@gnu.org, gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR python/12656 (API for special blocks)
References: <m339f4envs.fsf@redhat.com> <m3liswcz63.fsf@fleche.redhat.com>	<m34nzhchro.fsf@redhat.com> <m3ipnwbt3k.fsf@fleche.redhat.com>	<m3wrcb34ex.fsf@redhat.com> <m3d3e3a2ud.fsf@fleche.redhat.com>	<m3y5wj7vv9.fsf@redhat.com> <E1RFlAt-0004KD-FT@fencepost.gnu.org>
Reply-to: pmuldoon@redhat.com
X-URL: http://www.redhat.com
Date: Mon, 17 Oct 2011 12:49:00 -0000
In-Reply-To: <E1RFlAt-0004KD-FT@fencepost.gnu.org> (Eli Zaretskii's message of	"Mon, 17 Oct 2011 07:16:07 -0400")
Message-ID: <m3sjmr7rvm.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00461.txt.bz2

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Phil Muldoon <pmuldoon@redhat.com>
>> Cc: gdb-patches@sourceware.org
>> Date: Mon, 17 Oct 2011 11:31:06 +0100
>> 
>> doco ping
>
> Sorry, missed the original posting.
>
> I have a couple of comments:
>
>> +@defvar Block.is_global ()
>> +@code{True} if the @code{gdb.Block} object is the global block
>> +for the inferior, @code{False} if not.  This attribute is not
>> +writable.
>
> If this is an attribute, why do you use "()" on the @defvar line?

They used to be methods in a previous posting, I just forgot to remove
the "()"'s when I converted them to attributes.  Fixed locally.

> Also, what do you mean by "the global block for the inferior"? why
> "the" global block?  There could be more than one such block, right?

Oops, fixed and for static too.

> And the same goes for the static attribute.

Is this ok, or do you want me to re-post the patch?

Cheers,

Phil