Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Make map_symbol_filenames_psymtab interruptible
Date: Fri, 28 Oct 2011 15:59:00 -0000	[thread overview]
Message-ID: <m3sjmd88sz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAEG7qUw8OsAY+i45tYqfPcuKWZ2eauLOKnGcty6s68y2omYWWw@mail.gmail.com>	(Sterling Augustine's message of "Thu, 27 Oct 2011 12:57:15 -0700")

>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:

Sterling> Enclosed is a patch to allow interrupting
Sterling> map_symbol_filenames_psymtab. This patch adds a call to QUIT in
Sterling> map_symbol_filenames_psymtab, and several functions to cleanup data
Sterling> that would have leaked.

Thanks.

Sterling> +/* Free any memory associated with a completion list.  */
Sterling> +static void

Newline after comment.

Sterling> +free_completion_list (char ***list_ptr)
Sterling> +{
Sterling> +  int i = 0;
Sterling> +  char **list = *list_ptr;
Sterling> +  while (list[i] != NULL)

Newline after declaration block.

Sterling> +
Sterling> +static void
Sterling> +do_free_completion_list (void *list)

Comment before this function.

Ok with those changes.

Tom


  reply	other threads:[~2011-10-28 14:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27 20:29 Sterling Augustine
2011-10-28 15:59 ` Tom Tromey [this message]
2011-10-28 17:36   ` Sterling Augustine
2011-10-28 18:14     ` Sterling Augustine
2011-11-02 20:48       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sjmd88sz.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=saugustine@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox