From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84762-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18200 invoked by alias); 28 Oct 2011 14:55:59 -0000
Received: (qmail 18182 invoked by uid 22791); 28 Oct 2011 14:55:57 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Oct 2011 14:55:43 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9SEtgU7002798	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 28 Oct 2011 10:55:42 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9SEtfM9018320;	Fri, 28 Oct 2011 10:55:42 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9SEtecm013403;	Fri, 28 Oct 2011 10:55:40 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Make map_symbol_filenames_psymtab interruptible
References: <CAEG7qUw8OsAY+i45tYqfPcuKWZ2eauLOKnGcty6s68y2omYWWw@mail.gmail.com>
Date: Fri, 28 Oct 2011 15:59:00 -0000
In-Reply-To: <CAEG7qUw8OsAY+i45tYqfPcuKWZ2eauLOKnGcty6s68y2omYWWw@mail.gmail.com>	(Sterling Augustine's message of "Thu, 27 Oct 2011 12:57:15 -0700")
Message-ID: <m3sjmd88sz.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00765.txt.bz2

>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:

Sterling> Enclosed is a patch to allow interrupting
Sterling> map_symbol_filenames_psymtab. This patch adds a call to QUIT in
Sterling> map_symbol_filenames_psymtab, and several functions to cleanup data
Sterling> that would have leaked.

Thanks.

Sterling> +/* Free any memory associated with a completion list.  */
Sterling> +static void

Newline after comment.

Sterling> +free_completion_list (char ***list_ptr)
Sterling> +{
Sterling> +  int i = 0;
Sterling> +  char **list = *list_ptr;
Sterling> +  while (list[i] != NULL)

Newline after declaration block.

Sterling> +
Sterling> +static void
Sterling> +do_free_completion_list (void *list)

Comment before this function.

Ok with those changes.

Tom