Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFA: fix stray use of printf_filtered
Date: Mon, 22 Sep 2008 17:36:00 -0000	[thread overview]
Message-ID: <m3r67c2ifp.fsf@fleche.redhat.com> (raw)

I noticed that when I attach to a large program, gdb will paginate the
"Reading symbols" messages at odd places.

I tracked this down to a printf_filtered in
symbol_file_add_with_addrs_or_offsets.  The other prints in this
function are all unfiltered, and I think this one ought to be as well.

The change snuck in here:

    http://sourceware.org/ml/gdb-patches/2004-07/msg00497.html

I think it was probably unintentional.

Built and regtested on x86-64 (compile farm).

Please review.

Tom

:ADDPATCH symbols:

2008-09-22  Tom Tromey  <tromey@redhat.com>

	* symfile.c (symbol_file_add_with_addrs_or_offsets): Don't use
	printf_filtered.

diff --git a/gdb/symfile.c b/gdb/symfile.c
index d067d2b..656b5a9 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -1065,11 +1065,11 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd, int from_tty,
       && print_symbol_loading)
     {
       wrap_here ("");
-      printf_filtered (_("(no debugging symbols found)"));
+      printf_unfiltered (_("(no debugging symbols found)"));
       if (from_tty || info_verbose)
-        printf_filtered ("...");
+        printf_unfiltered ("...");
       else
-        printf_filtered ("\n");
+        printf_unfiltered ("\n");
       wrap_here ("");
     }
 


             reply	other threads:[~2008-09-22 17:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 17:36 Tom Tromey [this message]
2008-09-22 18:06 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r67c2ifp.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox