From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23582 invoked by alias); 22 Sep 2008 17:36:06 -0000 Received: (qmail 23566 invoked by uid 22791); 22 Sep 2008 17:36:05 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 22 Sep 2008 17:35:16 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m8MHZEuo020486 for ; Mon, 22 Sep 2008 13:35:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m8MHZD2D001014; Mon, 22 Sep 2008 13:35:13 -0400 Received: from opsy.redhat.com (vpn-10-112.bos.redhat.com [10.16.10.112]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m8MHZCtF009436; Mon, 22 Sep 2008 13:35:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C6AA037829B; Mon, 22 Sep 2008 11:34:34 -0600 (MDT) To: gdb-patches@sourceware.org Subject: RFA: fix stray use of printf_filtered From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Mon, 22 Sep 2008 17:36:00 -0000 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00466.txt.bz2 I noticed that when I attach to a large program, gdb will paginate the "Reading symbols" messages at odd places. I tracked this down to a printf_filtered in symbol_file_add_with_addrs_or_offsets. The other prints in this function are all unfiltered, and I think this one ought to be as well. The change snuck in here: http://sourceware.org/ml/gdb-patches/2004-07/msg00497.html I think it was probably unintentional. Built and regtested on x86-64 (compile farm). Please review. Tom :ADDPATCH symbols: 2008-09-22 Tom Tromey * symfile.c (symbol_file_add_with_addrs_or_offsets): Don't use printf_filtered. diff --git a/gdb/symfile.c b/gdb/symfile.c index d067d2b..656b5a9 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -1065,11 +1065,11 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd, int from_tty, && print_symbol_loading) { wrap_here (""); - printf_filtered (_("(no debugging symbols found)")); + printf_unfiltered (_("(no debugging symbols found)")); if (from_tty || info_verbose) - printf_filtered ("..."); + printf_unfiltered ("..."); else - printf_filtered ("\n"); + printf_unfiltered ("\n"); wrap_here (""); }