Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Chris Moller <cmoller@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Revised pr 9067 patch
Date: Wed, 03 Feb 2010 22:21:00 -0000	[thread overview]
Message-ID: <m3r5p2ot91.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B69D837.8080501@redhat.com> (Chris Moller's message of "Wed, 03 	Feb 2010 15:10:31 -0500")

>>>>> "Chris" == Chris Moller <cmoller@redhat.com> writes:

Chris> Fixes "Nested static causing infinite recursion in print."

There are still the formatting nits that I mentioned on the last
go-round.

Chris> +      void * statmem_obstack_top = NULL;

No space after *.

Chris> +	  /* set the current printed-statics stack top */

Comments in the GNU style are sentences.  They start with a capital
letter and end with a period and two spaces.

Chris> +	  /* In effect, a pop of the printed-statics stack */

Ditto.

Chris> +      first_dont_print = (CORE_ADDR *)obstack_base (&dont_print_statmem_obstack);

Line goes past column 79?  It seems to but sometimes it is hard to tell
in a patch.  Space after the closing paren of the cast.

Chris> +      i = obstack_object_size (&dont_print_statmem_obstack) / sizeof(CORE_ADDR);

Space after sizeof.  Too many columns, should line break.

Tom


  reply	other threads:[~2010-02-03 22:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 20:10 Chris Moller
2010-02-03 22:21 ` Tom Tromey [this message]
2010-02-04 14:14   ` Chris Moller
2010-02-04 15:45     ` Tom Tromey
2010-02-04 16:28     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r5p2ot91.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=cmoller@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox