From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26704 invoked by alias); 3 Feb 2010 22:21:38 -0000 Received: (qmail 26696 invoked by uid 22791); 3 Feb 2010 22:21:37 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Feb 2010 22:21:33 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o13MLW2s023869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Feb 2010 17:21:32 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o13MLVjL015542; Wed, 3 Feb 2010 17:21:32 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o13MLUDs017423; Wed, 3 Feb 2010 17:21:31 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 79476378181; Wed, 3 Feb 2010 15:21:30 -0700 (MST) From: Tom Tromey To: Chris Moller Cc: gdb-patches@sourceware.org Subject: Re: Revised pr 9067 patch References: <4B69D837.8080501@redhat.com> Reply-To: tromey@redhat.com Date: Wed, 03 Feb 2010 22:21:00 -0000 In-Reply-To: <4B69D837.8080501@redhat.com> (Chris Moller's message of "Wed, 03 Feb 2010 15:10:31 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00096.txt.bz2 >>>>> "Chris" == Chris Moller writes: Chris> Fixes "Nested static causing infinite recursion in print." There are still the formatting nits that I mentioned on the last go-round. Chris> + void * statmem_obstack_top = NULL; No space after *. Chris> + /* set the current printed-statics stack top */ Comments in the GNU style are sentences. They start with a capital letter and end with a period and two spaces. Chris> + /* In effect, a pop of the printed-statics stack */ Ditto. Chris> + first_dont_print = (CORE_ADDR *)obstack_base (&dont_print_statmem_obstack); Line goes past column 79? It seems to but sometimes it is hard to tell in a patch. Space after the closing paren of the cast. Chris> + i = obstack_object_size (&dont_print_statmem_obstack) / sizeof(CORE_ADDR); Space after sizeof. Too many columns, should line break. Tom