Re: [RFA 3/5] New patches to support --enable-targets=all for mingw64

Re: [RFA 3/5] New patches to support --enable-targets=all for mingw64

[Tom Tromey]

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> 2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>
Pierre> 	* coffread.c (struct coff_symbol): Change c_value type from `long' to
Pierre> 	`CORE_ADDRESS' as it might contain target addresses.

This is ok.

Tom

RE: [RFA 3/5] New patches to support --enable-targets=all for mingw64

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Friday, September 10, 2010 5:46 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA 3/5] New patches to support --enable-targets=all for
> mingw64
> 
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
> writes:
> 
> Pierre> 2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>
> Pierre> 	* coffread.c (struct coff_symbol): Change c_value type from
> `long' to
> Pierre> 	`CORE_ADDRESS' as it might contain target addresses.
> 
> This is ok.

Thanks, patch applied.

Pierre

[RFA 3/5] New patches to support --enable-targets=all for mingw64

[Pierre Muller]

  I tried to compile GDB with
--enable-targets=all for x86_64-w64-mingw32
target.
  As 'long' type is 4-byte while pointer type is 8-byte,
this target is quite sensitive to so 'dirty' code
lying around like casting 'long' or 'unsigned long' to pointers...

  I had to fix several sources to be able to 
successfully compile GDB with those configuration options.


3) Change some types from 'long' to 'CORE_ADDRESS',
if they could carry pointers.
 in coffread.c


Pierre Muller
Pascal language support maintainer for GDB

2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>

	* coffread.c (struct coff_symbol): Change c_value type from `long' to
	`CORE_ADDRESS' as it might contain target addresses.

Index: src/gdb/coffread.c
===================================================================
RCS file: /cvs/src/src/gdb/coffread.c,v
retrieving revision 1.109
diff -u -p -r1.109 coffread.c
--- src/gdb/coffread.c	9 Aug 2010 19:42:46 -0000	1.109
+++ src/gdb/coffread.c	9 Sep 2010 16:39:57 -0000
@@ -131,7 +131,7 @@ struct coff_symbol
     char *c_name;
     int c_symnum;		/* symbol number of this entry */
     int c_naux;			/* 0 if syment only, 1 if syment + auxent, etc */
-    long c_value;
+    CORE_ADDR c_value;
     int c_sclass;
     int c_secnum;
     unsigned int c_type;