From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] tracepoint: add new trace command "printf"[1] gdbserver
Date: Fri, 11 Feb 2011 21:31:00 -0000 [thread overview]
Message-ID: <m3r5bejm1i.fsf@fleche.redhat.com> (raw)
In-Reply-To: <AANLkTi=urZAz1paHYCfHj39qX=Q3pQ=PMERAVrfVD+TE@mail.gmail.com> (Hui Zhu's message of "Sat, 5 Feb 2011 00:00:52 +0800")
>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>> To make the gdbserver support %s.
Oops, I missed this when reviewing your earlier patch.
Sorry about that.
>> +int
>> +tp_printf(const char *format, ...)
Space before open paren.
>> + va_end(ap);
Likewise.
>> + argv = (void *)(unsigned long)top;
Spacing.
There are several more spacing bugs, please fix them all.
I didn't go read the other patch to try to deduce the format of the
printf opcode to see if it all makes sense. Documentation would help.
Tom
next prev parent reply other threads:[~2011-02-11 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 16:29 Hui Zhu
2011-01-28 6:41 ` Hui Zhu
2011-02-04 16:01 ` Hui Zhu
2011-02-11 21:31 ` Tom Tromey [this message]
2011-02-17 9:54 ` Hui Zhu
2011-02-21 8:18 ` Hui Zhu
2011-02-24 7:46 ` Joel Brobecker
2011-02-24 8:37 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5bejm1i.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox