From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78159-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 589 invoked by alias); 11 Feb 2011 21:31:29 -0000
Received: (qmail 528 invoked by uid 22791); 11 Feb 2011 21:31:29 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_RG,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Feb 2011 21:31:25 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1BLVM2u010082	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 11 Feb 2011 16:31:23 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1BLVMgL030251;	Fri, 11 Feb 2011 16:31:22 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1BLVL5S022325;	Fri, 11 Feb 2011 16:31:22 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id AA4F2378338; Fri, 11 Feb 2011 14:31:21 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] tracepoint: add new trace command "printf"[1] gdbserver
References: <AANLkTikPdWq8kQWs0f4B3XdYmjHx5LshN5K_Xt=DMx29@mail.gmail.com>	<AANLkTim4+iQZHQhFrQBp-dz_jh65KsM45JZ6nR0qnHTi@mail.gmail.com>	<AANLkTi=urZAz1paHYCfHj39qX=Q3pQ=PMERAVrfVD+TE@mail.gmail.com>
Date: Fri, 11 Feb 2011 21:31:00 -0000
In-Reply-To: <AANLkTi=urZAz1paHYCfHj39qX=Q3pQ=PMERAVrfVD+TE@mail.gmail.com>	(Hui Zhu's message of "Sat, 5 Feb 2011 00:00:52 +0800")
Message-ID: <m3r5bejm1i.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00226.txt.bz2

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> To make the gdbserver support %s.

Oops, I missed this when reviewing your earlier patch.
Sorry about that.

>> +int
>> +tp_printf(const char *format, ...)

Space before open paren.

>> +  va_end(ap);

Likewise.

>> +	    argv = (void *)(unsigned long)top;

Spacing.

There are several more spacing bugs, please fix them all.

I didn't go read the other patch to try to deduce the format of the
printf opcode to see if it all makes sense.  Documentation would help.

Tom