Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
	       Guillaume Leconte <guillaume.leconte@gmail.com>,
	       Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] delete a range of display numbers
Date: Fri, 18 Feb 2011 15:14:00 -0000	[thread overview]
Message-ID: <m3r5b5z877.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201102181159.00201.pedro@codesourcery.com> (Pedro Alves's	message of "Fri, 18 Feb 2011 11:58:59 +0000")

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> The "delete" breakpoint command accepts ranges as
Pedro> well, and even has code that handles convenience
Pedro> variables mixed with the numbers.  I think we should
Pedro> reuse that instead of re-adding code that parses ranges.
Pedro> Might as well make the "delete display" command
Pedro> implementation look more like the "delete" command
Pedro> implementation.  Here's a quick cut at it.

I've been thinking of starting a cli/cli-utils.c file and putting shared
CLI parsing code there.  This seems like a good candidate, WDYT?
I can do the moving.

Pedro>    if (p == NULL)
Pedro> -    /* Empty line means refer to the last breakpoint.  */
Pedro> -    return breakpoint_count;
Pedro> +    return 0;

I was surprised that this didn't imply any other changes, but I looked
at a bunch of calls into this code and I couldn't see anything.

Tom


  parent reply	other threads:[~2011-02-18 15:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18  9:47 Guillaume Leconte
2011-02-18 10:30 ` Guillaume Leconte
2011-02-18 11:08 ` Eli Zaretskii
2011-02-18 11:48   ` Guillaume Leconte
2011-02-18 12:17     ` Pedro Alves
2011-02-18 14:41       ` Guillaume Leconte
2011-02-18 15:14       ` Tom Tromey [this message]
2011-02-18 15:58         ` Pedro Alves
2011-02-18 16:48           ` Tom Tromey
2011-02-18 16:57             ` Pedro Alves
2011-02-18 17:41               ` Eli Zaretskii
2011-02-18 17:54                 ` Pedro Alves
2011-02-18 17:54                   ` Michael Snyder
2011-02-18 18:06                     ` Pedro Alves
2011-03-14 21:24                       ` [patch+docs] make 'disable|enable display' also accept ranges (Re: [patch] delete a range of display numbers) Pedro Alves
2011-03-14 21:34                         ` Eli Zaretskii
2011-03-15 14:43                           ` Pedro Alves
2011-02-18 18:17                     ` [patch] delete a range of display numbers Eli Zaretskii
2011-02-18 17:52       ` Michael Snyder
2011-02-18 17:57         ` Pedro Alves
2011-02-18 17:44 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r5b5z877.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=guillaume.leconte@gmail.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox