From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15741 invoked by alias); 18 Feb 2011 15:14:26 -0000 Received: (qmail 15725 invoked by uid 22791); 18 Feb 2011 15:14:25 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 15:14:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1IFE6f2032090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Feb 2011 10:14:06 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1IFE6Kn028776; Fri, 18 Feb 2011 10:14:06 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1IFE5lr013633; Fri, 18 Feb 2011 10:14:05 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id BD60D378509; Fri, 18 Feb 2011 08:14:04 -0700 (MST) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Guillaume Leconte , Eli Zaretskii Subject: Re: [patch] delete a range of display numbers References: <83vd0hvdls.fsf@gnu.org> <201102181159.00201.pedro@codesourcery.com> Date: Fri, 18 Feb 2011 15:14:00 -0000 In-Reply-To: <201102181159.00201.pedro@codesourcery.com> (Pedro Alves's message of "Fri, 18 Feb 2011 11:58:59 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00462.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> The "delete" breakpoint command accepts ranges as Pedro> well, and even has code that handles convenience Pedro> variables mixed with the numbers. I think we should Pedro> reuse that instead of re-adding code that parses ranges. Pedro> Might as well make the "delete display" command Pedro> implementation look more like the "delete" command Pedro> implementation. Here's a quick cut at it. I've been thinking of starting a cli/cli-utils.c file and putting shared CLI parsing code there. This seems like a good candidate, WDYT? I can do the moving. Pedro> if (p == NULL) Pedro> - /* Empty line means refer to the last breakpoint. */ Pedro> - return breakpoint_count; Pedro> + return 0; I was surprised that this didn't imply any other changes, but I looked at a bunch of calls into this code and I couldn't see anything. Tom