[RFA/testsuite] minor adjustments in gdb.python/py-block.exp

[RFA/testsuite] minor adjustments in gdb.python/py-block.exp

[Joel Brobecker]

Hello,

I wouldn't mind a spot-check on this patch, particularly in the use
of prepare_for_testing.  I think it's correct, and it works on
x86_64-linux, but my command of TCL sometimes tricks me.

gdb/testsuite/ChangeLog:

        * gdb.python/py-block.exp: Simplify using prepare_for_testing.
        Delete variable binfile, no longer use.  Add or modify test
        comments to make them unique.

Tested on x86_64-linux.

Thanks,
-- 
Joel

---
 gdb/testsuite/gdb.python/py-block.exp |   20 +++++++-------------
 1 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/gdb/testsuite/gdb.python/py-block.exp b/gdb/testsuite/gdb.python/py-block.exp
index b1a49d6..c400df7 100644
--- a/gdb/testsuite/gdb.python/py-block.exp
+++ b/gdb/testsuite/gdb.python/py-block.exp
@@ -24,18 +24,10 @@ load_lib gdb-python.exp
 
 set testfile "py-block"
 set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
-if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-    untested "Couldn't compile ${srcfile}"
+if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
     return -1
 }
 
-# Start with a fresh gdb.
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 # Skip all tests if Python scripting is not enabled.
 if { [skip_python_tests] } { continue }
 
@@ -60,11 +52,13 @@ gdb_test "python print block.end" "${decimal}" "Check end not None"
 gdb_test_no_output "python block = block.superblock" "Get superblock"
 gdb_test "python print block.function" "None" "Second anonymous block"
 gdb_test_no_output "python block = block.superblock" "Get superblock 2"
-gdb_test "python print block.function" "block_func"
+gdb_test "python print block.function" "block_func" \
+         "Print superblock 2 function"
 
 # Switch frames, then test for main block.
 gdb_test "up" ".*"
-gdb_py_test_silent_cmd "python frame = gdb.selected_frame()" "Get Frame" 0
-gdb_py_test_silent_cmd "python block = frame.block()" "Get block" 0
-gdb_test "python print block" "<gdb.Block object at $hex>" "Check block not None"
+gdb_py_test_silent_cmd "python frame = gdb.selected_frame()" "Get Frame 2" 0
+gdb_py_test_silent_cmd "python block = frame.block()" "Get Frame 2's block" 0
+gdb_test "python print block" "<gdb.Block object at $hex>" \
+         "Check Frame 2's block not None"
 gdb_test "python print block.function" "main" "main block"
-- 
1.7.1

Re: [RFA/testsuite] minor adjustments in gdb.python/py-block.exp

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel>         * gdb.python/py-block.exp: Simplify using prepare_for_testing.
Joel>         Delete variable binfile, no longer use.  Add or modify test
Joel>         comments to make them unique.

It looks ok to me.

Tom

Re: [RFA/testsuite] minor adjustments in gdb.python/py-block.exp

[Joel Brobecker]

> Joel>         * gdb.python/py-block.exp: Simplify using prepare_for_testing.
> Joel>         Delete variable binfile, no longer use.  Add or modify test
> Joel>         comments to make them unique.
> 
> It looks ok to me.

Thanks for taking a look! I've just committed the patch.

-- 
Joel