Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/2] Fix decode_locdesc for gcc-4.7.x optimized DWARF
Date: Wed, 27 Jul 2011 17:09:00 -0000	[thread overview]
Message-ID: <m3r55b8xof.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110727165744.GA27603@host1.jankratochvil.net> (Jan	Kratochvil's message of "Wed, 27 Jul 2011 18:57:44 +0200")

Tom> I don't understand why DWARF_VALUE_REGISTER is ok here,

Jan> Made there a new comment - Drow says it is needed.

Tom> or why DWARF_VALUE_LITERAL is not.

Jan> That is for DW_OP_implicit_value (DW_OP_lit* does not use
Jan> DWARF_VALUE_LITERAL).  It hasn't been supported so far and I do not
Jan> think the callers of decode_locdesc need DW_OP_implicit_value.  I
Jan> find it outside of the scope of this patch, it is definitely not a
Jan> regression.

Thanks.
It is fine by me.

Tom


  reply	other threads:[~2011-07-27 17:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27 16:22 Jan Kratochvil
2011-07-27 16:58 ` Tom Tromey
2011-07-27 17:02   ` Jan Kratochvil
2011-07-27 17:09     ` Tom Tromey [this message]
2011-07-27 17:33       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r55b8xof.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox