From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31112 invoked by alias); 27 Jul 2011 17:02:12 -0000 Received: (qmail 31103 invoked by uid 22791); 27 Jul 2011 17:02:11 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Jul 2011 17:01:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6RH1soe020509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Jul 2011 13:01:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6RH1sm0002648; Wed, 27 Jul 2011 13:01:54 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6RH1qf5017471; Wed, 27 Jul 2011 13:01:53 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/2] Fix decode_locdesc for gcc-4.7.x optimized DWARF References: <20110727153041.GB9736@host1.jankratochvil.net> <20110727165744.GA27603@host1.jankratochvil.net> Date: Wed, 27 Jul 2011 17:09:00 -0000 In-Reply-To: <20110727165744.GA27603@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 27 Jul 2011 18:57:44 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00770.txt.bz2 Tom> I don't understand why DWARF_VALUE_REGISTER is ok here, Jan> Made there a new comment - Drow says it is needed. Tom> or why DWARF_VALUE_LITERAL is not. Jan> That is for DW_OP_implicit_value (DW_OP_lit* does not use Jan> DWARF_VALUE_LITERAL). It hasn't been supported so far and I do not Jan> think the callers of decode_locdesc need DW_OP_implicit_value. I Jan> find it outside of the scope of this patch, it is definitely not a Jan> regression. Thanks. It is fine by me. Tom