From: Tom Tromey <tromey@redhat.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: remote-sim.h
Date: Wed, 02 Nov 2011 17:02:00 -0000 [thread overview]
Message-ID: <m3r51qxxts.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1996AF78-76A1-4104-A1AE-DF674CA3E6CE@comcast.net> (Mike Stump's message of "Tue, 1 Nov 2011 12:49:42 -0700")
>>>>> "Mike" == Mike Stump <mikestump@comcast.net> writes:
Tom> remote-sim.h is the only reference I see to CORE_ADDR_TYPE.
Tom> I don't know the history but replacing it with bfd_vma seems like the
Tom> right thing.
Mike> Ah, yes, I agree.
The patch to do that is preapproved, with a ChangeLog entry of course.
Mike> Another patch to get the overlay code to work is below. It just
Mike> replaces unsigned int (32-bits for me) with CORE_ADDR, as
Mike> otherwise int doesn't have enough bits to actually hold a long
Mike> (64-bits for me).
Needs a ChangeLog but is otherwise ok.
Tom
next prev parent reply other threads:[~2011-11-02 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 23:24 remote-sim.h Mike Stump
2011-11-01 3:55 ` remote-sim.h Mike Frysinger
2011-11-01 5:38 ` remote-sim.h Mike Stump
2011-11-01 18:55 ` remote-sim.h Tom Tromey
2011-11-01 19:50 ` remote-sim.h Mike Stump
2011-11-02 17:02 ` Tom Tromey [this message]
2011-11-06 17:35 ` remote-sim.h Mike Frysinger
2011-11-06 18:31 ` remote-sim.h Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r51qxxts.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mikestump@comcast.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox