From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2944 invoked by alias); 2 Nov 2011 17:02:21 -0000 Received: (qmail 2928 invoked by uid 22791); 2 Nov 2011 17:02:18 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 17:01:57 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA2H1sFr000522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Nov 2011 13:01:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA2H1rEZ010275; Wed, 2 Nov 2011 13:01:53 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA2H1pro014418; Wed, 2 Nov 2011 13:01:52 -0400 From: Tom Tromey To: Mike Stump Cc: Mike Frysinger , gdb-patches@sourceware.org Subject: Re: remote-sim.h References: <42696E6D-92F3-4F66-B2C9-D79C76B12D2F@comcast.net> <201110312354.53063.vapier@gentoo.org> <593EB847-F177-4D84-8DB3-30064C53907E@comcast.net> <1996AF78-76A1-4104-A1AE-DF674CA3E6CE@comcast.net> Date: Wed, 02 Nov 2011 17:02:00 -0000 In-Reply-To: <1996AF78-76A1-4104-A1AE-DF674CA3E6CE@comcast.net> (Mike Stump's message of "Tue, 1 Nov 2011 12:49:42 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00040.txt.bz2 >>>>> "Mike" == Mike Stump writes: Tom> remote-sim.h is the only reference I see to CORE_ADDR_TYPE. Tom> I don't know the history but replacing it with bfd_vma seems like the Tom> right thing. Mike> Ah, yes, I agree. The patch to do that is preapproved, with a ChangeLog entry of course. Mike> Another patch to get the overlay code to work is below. It just Mike> replaces unsigned int (32-bits for me) with CORE_ADDR, as Mike> otherwise int doesn't have enough bits to actually hold a long Mike> (64-bits for me). Needs a ChangeLog but is otherwise ok. Tom