Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix C++ demangling of minsyms with symver
Date: Thu, 02 Jun 2011 18:04:00 -0000	[thread overview]
Message-ID: <m3pqmwm7pa.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110602153308.GA21368@host1.jankratochvil.net> (Jan	Kratochvil's message of "Thu, 2 Jun 2011 17:33:08 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> 	* symtab.c (symbol_find_demangled_name): New parameter objfile.  Always
Jan> 	call bfd_demangle, not cplus_demangle.
Jan> 	(symbol_set_names): Pass OBJFILE.

The patch looks reasonable in itself, but I wonder about the other
untouched calls to cplus_demangle.

Tom


  reply	other threads:[~2011-06-02 18:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 15:33 Jan Kratochvil
2011-06-02 18:04 ` Tom Tromey [this message]
2011-06-02 18:24   ` Jan Kratochvil
2011-06-02 21:45 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pqmwm7pa.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox