From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6161 invoked by alias); 2 Jun 2011 18:04:03 -0000 Received: (qmail 6153 invoked by uid 22791); 2 Jun 2011 18:04:03 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jun 2011 18:03:47 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p52I3lMp014091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Jun 2011 14:03:47 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p52I3kR7010229; Thu, 2 Jun 2011 14:03:47 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p52I3kEf013381; Thu, 2 Jun 2011 14:03:46 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1592B378142; Thu, 2 Jun 2011 12:03:45 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix C++ demangling of minsyms with symver References: <20110602153308.GA21368@host1.jankratochvil.net> Date: Thu, 02 Jun 2011 18:04:00 -0000 In-Reply-To: <20110602153308.GA21368@host1.jankratochvil.net> (Jan Kratochvil's message of "Thu, 2 Jun 2011 17:33:08 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00029.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> * symtab.c (symbol_find_demangled_name): New parameter objfile. Always Jan> call bfd_demangle, not cplus_demangle. Jan> (symbol_set_names): Pass OBJFILE. The patch looks reasonable in itself, but I wonder about the other untouched calls to cplus_demangle. Tom