Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: FYI: more cleanup fixes
Date: Thu, 30 Jun 2011 19:29:00 -0000	[thread overview]
Message-ID: <m3pqlvf78p.fsf@fleche.redhat.com> (raw)

I'm checking this in on the trunk.

One last round of cleanup fixes.

Built and regtested by the buildbot.

I neglected to mention in the last email: if anybody wants the latest
version of the plugin, just let me know.

Tom

2011-06-30  Tom Tromey  <tromey@redhat.com>

	* varobj.c (varobj_create): Call do_cleanups on early exit path.
	* valops.c (find_overload_match): Call do_cleanups on early exit
	path.
	* solib.c (solib_find): Call do_cleanups on early exit path.

Index: solib.c
===================================================================
RCS file: /cvs/src/src/gdb/solib.c,v
retrieving revision 1.148
diff -u -r1.148 solib.c
--- solib.c	17 Apr 2011 18:38:45 -0000	1.148
+++ solib.c	30 Jun 2011 19:26:24 -0000
@@ -254,6 +254,7 @@
   if (remote_filename_p (temp_pathname))
     {
       *fd = -1;
+      do_cleanups (old_chain);
       return temp_pathname;
     }
 
Index: valops.c
===================================================================
RCS file: /cvs/src/src/gdb/valops.c,v
retrieving revision 1.280
diff -u -r1.280 valops.c
--- valops.c	27 Jun 2011 19:21:50 -0000	1.280
+++ valops.c	30 Jun 2011 19:26:24 -0000
@@ -2585,6 +2585,7 @@
 	  if (*valp)
 	    {
 	      *staticp = 1;
+	      do_cleanups (all_cleanups);
 	      return 0;
 	    }
 	}
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.178
diff -u -r1.178 varobj.c
--- varobj.c	24 Jun 2011 19:47:37 -0000	1.178
+++ varobj.c	30 Jun 2011 19:26:24 -0000
@@ -580,6 +580,7 @@
          return a sensible error.  */
       if (!gdb_parse_exp_1 (&p, block, 0, &var->root->exp))
 	{
+	  do_cleanups (old_chain);
 	  return NULL;
 	}
 


             reply	other threads:[~2011-06-30 19:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 19:29 Tom Tromey [this message]
2011-07-01  2:02 ` Yao Qi
2011-07-01 13:24   ` Tom Tromey
  -- strict thread matches above, loose matches on Subject: below --
2011-06-30 18:47 Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pqlvf78p.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox