From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26466 invoked by alias); 30 Jun 2011 19:29:46 -0000 Received: (qmail 26456 invoked by uid 22791); 30 Jun 2011 19:29:46 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Jun 2011 19:29:28 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5UJTSCL007433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 Jun 2011 15:29:28 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5UJTRIF001838; Thu, 30 Jun 2011 15:29:28 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5UJTQ66021034; Thu, 30 Jun 2011 15:29:27 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: FYI: more cleanup fixes Date: Thu, 30 Jun 2011 19:29:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00497.txt.bz2 I'm checking this in on the trunk. One last round of cleanup fixes. Built and regtested by the buildbot. I neglected to mention in the last email: if anybody wants the latest version of the plugin, just let me know. Tom 2011-06-30 Tom Tromey * varobj.c (varobj_create): Call do_cleanups on early exit path. * valops.c (find_overload_match): Call do_cleanups on early exit path. * solib.c (solib_find): Call do_cleanups on early exit path. Index: solib.c =================================================================== RCS file: /cvs/src/src/gdb/solib.c,v retrieving revision 1.148 diff -u -r1.148 solib.c --- solib.c 17 Apr 2011 18:38:45 -0000 1.148 +++ solib.c 30 Jun 2011 19:26:24 -0000 @@ -254,6 +254,7 @@ if (remote_filename_p (temp_pathname)) { *fd = -1; + do_cleanups (old_chain); return temp_pathname; } Index: valops.c =================================================================== RCS file: /cvs/src/src/gdb/valops.c,v retrieving revision 1.280 diff -u -r1.280 valops.c --- valops.c 27 Jun 2011 19:21:50 -0000 1.280 +++ valops.c 30 Jun 2011 19:26:24 -0000 @@ -2585,6 +2585,7 @@ if (*valp) { *staticp = 1; + do_cleanups (all_cleanups); return 0; } } Index: varobj.c =================================================================== RCS file: /cvs/src/src/gdb/varobj.c,v retrieving revision 1.178 diff -u -r1.178 varobj.c --- varobj.c 24 Jun 2011 19:47:37 -0000 1.178 +++ varobj.c 30 Jun 2011 19:26:24 -0000 @@ -580,6 +580,7 @@ return a sensible error. */ if (!gdb_parse_exp_1 (&p, block, 0, &var->root->exp)) { + do_cleanups (old_chain); return NULL; }