Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Add an unwinder for JIT compiled code.
Date: Thu, 14 Jul 2011 21:05:00 -0000	[thread overview]
Message-ID: <m3pqlcd9xz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1310588850-10967-3-git-send-email-sanjoy@playingwithpointers.com>	(Sanjoy Das's message of "Thu, 14 Jul 2011 01:57:29 +0530")

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> 	* jit-reader.h: Added jit_prepend_unwinder.

This mentions the wrong file.

Otherwise this one seems pretty good, though again, I would appreciate
further reviews by others.

Tom


  reply	other threads:[~2011-07-14 17:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 20:24 [PATCH 1/4] jit-reader.h: describe interface implemented by the JIT readers Sanjoy Das
2011-07-13 20:24 ` [PATCH 4/4] Activate JIT code unwinder for i386 Sanjoy Das
2011-07-14 17:55   ` Tom Tromey
2011-07-14 17:58     ` Sanjoy Das
2011-07-13 20:52 ` [PATCH 2/4] Add symbol-handling callbacks to the jit-reader interface Sanjoy Das
2011-07-14  1:39 ` [PATCH 3/4] Add an unwinder for JIT compiled code Sanjoy Das
2011-07-14 21:05   ` Tom Tromey [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-07-05  6:27 [PATCH 1/4] jit-reader.h: describe interface implemented by the JIT readers Sanjoy Das
2011-07-05  7:53 ` [PATCH 3/4] Add an unwinder for JIT compiled code Sanjoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pqlcd9xz.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sanjoy@playingwithpointers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox