From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5513 invoked by alias); 14 Jul 2011 17:55:07 -0000 Received: (qmail 5503 invoked by uid 22791); 14 Jul 2011 17:55:06 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jul 2011 17:54:52 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6EHso4G031705 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Jul 2011 13:54:50 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6EHso8p029614; Thu, 14 Jul 2011 13:54:50 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6EHsmDQ017211; Thu, 14 Jul 2011 13:54:49 -0400 From: Tom Tromey To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Add an unwinder for JIT compiled code. References: <1310588850-10967-1-git-send-email-sanjoy@playingwithpointers.com> <1310588850-10967-3-git-send-email-sanjoy@playingwithpointers.com> Date: Thu, 14 Jul 2011 21:05:00 -0000 In-Reply-To: <1310588850-10967-3-git-send-email-sanjoy@playingwithpointers.com> (Sanjoy Das's message of "Thu, 14 Jul 2011 01:57:29 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00376.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> * jit-reader.h: Added jit_prepend_unwinder. This mentions the wrong file. Otherwise this one seems pretty good, though again, I would appreciate further reviews by others. Tom