From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Incorrect output in error case
Date: Wed, 30 Nov 2011 15:56:00 -0000 [thread overview]
Message-ID: <m3pqg9ioyq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4ED3C600.9020209@broadcom.com> (Andrew Burgess's message of "Mon, 28 Nov 2011 17:33:52 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
Andrew> I believe the "in woof.c" output from gdb is a mistake caused by
Andrew> missing braces in an else clause.
I agree.
Andrew> Patch/Changelog below for review. I think this is an "obvious" fix,
Andrew> so I'll commit this in a week unless someones says not to.
Andrew> 2011-11-28 Andrew Burgess <aburgess@broadcom.com>
Andrew> * source.c (print_source_lines_base): Fix missing braces on else
Andrew> clause leading to additional output.
Ok.
Tom
next prev parent reply other threads:[~2011-11-30 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 17:34 Andrew Burgess
2011-11-30 15:56 ` Tom Tromey [this message]
2011-12-01 10:39 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pqg9ioyq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox