From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85668-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11770 invoked by alias); 30 Nov 2011 15:56:43 -0000
Received: (qmail 11751 invoked by uid 22791); 30 Nov 2011 15:56:42 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Nov 2011 15:56:20 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAUFuGad000668	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 30 Nov 2011 10:56:16 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAUFuGOI019842;	Wed, 30 Nov 2011 10:56:16 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pAUFuEDs001552;	Wed, 30 Nov 2011 10:56:14 -0500
From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Incorrect output in error case
References: <4ED3C600.9020209@broadcom.com>
Date: Wed, 30 Nov 2011 15:56:00 -0000
In-Reply-To: <4ED3C600.9020209@broadcom.com> (Andrew Burgess's message of	"Mon, 28 Nov 2011 17:33:52 +0000")
Message-ID: <m3pqg9ioyq.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00845.txt.bz2

>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:

Andrew> I believe the "in woof.c" output from gdb is a mistake caused by
Andrew> missing braces in an else clause.

I agree.

Andrew> Patch/Changelog below for review.  I think this is an "obvious" fix,
Andrew> so I'll commit this in a week unless someones says not to.

Andrew> 2011-11-28  Andrew Burgess  <aburgess@broadcom.com>

Andrew> 	* source.c (print_source_lines_base): Fix missing braces on else
Andrew> 	clause leading to additional output.

Ok.

Tom