From: Tom Tromey <tromey@redhat.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Simplify MI breakpoint setting
Date: Fri, 07 Aug 2009 18:52:00 -0000 [thread overview]
Message-ID: <m3ocqrcybb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200908011113.32939.vladimir@codesourcery.com> (Vladimir Prus's message of "Sat\, 1 Aug 2009 11\:13\:32 +0400")
>>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:
Volodya> Further, set_breakpoint appears to be trivial and useless
Volodya> wrapper over break_command_really. This patch cleans that
Volodya> up. Are breakpoint.{c,h} changes OK?
I think the point of this is not to expose all the parameters of
break_command_really outside of breakpoint.c.
So, unless there is a problem with the current approach, I would prefer
not to change it.
In the alternative, if somebody does want to approve this, I would like
to recommend renaming break_command_really, as I don't think that is a
very good name for a public function.
Tom
next prev parent reply other threads:[~2009-08-07 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 7:13 Vladimir Prus
2009-08-07 18:52 ` Tom Tromey [this message]
2009-08-24 10:55 ` Vladimir Prus
2009-08-31 23:35 ` Tom Tromey
2009-09-01 5:16 ` Vladimir Prus
2009-09-07 23:00 ` Matt Rice
2009-09-08 5:20 ` Vladimir Prus
2009-09-08 7:59 ` Matt Rice
2009-09-08 8:15 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ocqrcybb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox