From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Sami Wagiaalla <swagiaal@redhat.com>
Subject: Re: [patch] Fix C++ leading :: (PR c++/11703 and PR gdb/1448)
Date: Mon, 28 Jun 2010 18:28:00 -0000 [thread overview]
Message-ID: <m3ocevxb90.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100626082205.GA30439@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 26 Jun 2010 10:22:05 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Maybe a more clear/straightforward conditional could be chosen than
Jan> `first_was_coloncolon && first_iter' to just really check
Jan> yylval.sval.ptr has been initialized. But from some higher level
Jan> point of view the equivalent conditional `first_was_coloncolon &&
Jan> first_iter' makes sense there.
I agree.
Jan> 2010-06-26 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix PR c++/11703 and PR gdb/1448.
Jan> * c-exp.y (yylex) <last_was_coloncolon && first_was_coloncolon>: Add
Jan> FIRST_ITER check.
Jan> 2010-06-26 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Test PR c++/11703 and PR gdb/1448.
Jan> * gdb.cp/namespace.exp (whatis ::C::cOtherFileVar)
Jan> (print ::C::cOtherFileVar)
Jan> (print ::C::OtherFileClass::cOtherFileClassVar): Remove KFAIL for
Jan> c++/11703.
Jan> (ptype ::C::NestedClass): Remove KFAIL for gdb/1448.
This is ok. Thanks for fixing this.
Tom
next prev parent reply other threads:[~2010-06-28 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 8:22 Jan Kratochvil
2010-06-28 18:28 ` Tom Tromey [this message]
2010-06-28 20:19 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ocevxb90.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=swagiaal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox