From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8656 invoked by alias); 28 Jun 2010 18:28:36 -0000 Received: (qmail 8567 invoked by uid 22791); 28 Jun 2010 18:28:35 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Jun 2010 18:28:31 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5SISUvU001916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Jun 2010 14:28:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5SISTwc004446; Mon, 28 Jun 2010 14:28:29 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5SISSjA028798; Mon, 28 Jun 2010 14:28:29 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3F72B378967; Mon, 28 Jun 2010 12:28:27 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Sami Wagiaalla Subject: Re: [patch] Fix C++ leading :: (PR c++/11703 and PR gdb/1448) References: <20100626082205.GA30439@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Mon, 28 Jun 2010 18:28:00 -0000 In-Reply-To: <20100626082205.GA30439@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 26 Jun 2010 10:22:05 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00645.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Maybe a more clear/straightforward conditional could be chosen than Jan> `first_was_coloncolon && first_iter' to just really check Jan> yylval.sval.ptr has been initialized. But from some higher level Jan> point of view the equivalent conditional `first_was_coloncolon && Jan> first_iter' makes sense there. I agree. Jan> 2010-06-26 Jan Kratochvil Jan> Fix PR c++/11703 and PR gdb/1448. Jan> * c-exp.y (yylex) : Add Jan> FIRST_ITER check. Jan> 2010-06-26 Jan Kratochvil Jan> Test PR c++/11703 and PR gdb/1448. Jan> * gdb.cp/namespace.exp (whatis ::C::cOtherFileVar) Jan> (print ::C::cOtherFileVar) Jan> (print ::C::OtherFileClass::cOtherFileClassVar): Remove KFAIL for Jan> c++/11703. Jan> (ptype ::C::NestedClass): Remove KFAIL for gdb/1448. This is ok. Thanks for fixing this. Tom