Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: RFC: libunwind-frame.c -vs- optimized-out
Date: Fri, 02 Jul 2010 21:22:00 -0000	[thread overview]
Message-ID: <m3ocepk2a6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100702210728.GA631@host0.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Fri, 2 Jul 2010 23:07:29 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> Yes, it also seems to me so.  Your change is an incoremental improvement.

Jan> If there are no regressions approving the check-in.

I will commit it shortly.

I compared this patch against the test results from a revision before
the optimized-out changes.  I had to do this by hand because in the
meantime there were a lot of test suite changes.

(And as an aside, our test suite is still very noisy: we have a lot of
tests named "set print sevenbit-strings", among other things.)

I also compared to HEAD.  Here the patch fixes a lot of regressions.
According to gcc/contrib/compare_tests it also causes:

gdb.mi/mi2-break.exp: list of breakpoints
gdb.mi/mi-break.exp: list of breakpoints
gdb.mi/mi-nonstop.exp: check varobj, w1, 1

... but all of these are duplicate test names and I think the script is
confused about PASS -vs- XFAIL.

(Also the last test there is probably misnamed.)

Tom


      reply	other threads:[~2010-07-02 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 19:42 Tom Tromey
2010-07-02 21:07 ` Jan Kratochvil
2010-07-02 21:22   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ocepk2a6.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox