Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: RFC: libunwind-frame.c -vs- optimized-out
Date: Fri, 02 Jul 2010 21:07:00 -0000	[thread overview]
Message-ID: <20100702210728.GA631@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <m3d3v5llg3.fsf@fleche.redhat.com>

On Fri, 02 Jul 2010 21:42:36 +0200, Tom Tromey wrote:
> So, this seems like the logic is possibly backward.

Yes, it also seems to me so.  Your change is an incoremental improvement.

If there are no regressions approving the check-in.


> The appended patch fixes the IA-64 regressions.  However, I am reluctant
> to commit it without understanding what is going on here.

	[commit] Update libunwind & ia64 unwinders
	From: Joel Brobecker
	http://sourceware.org/ml/gdb-patches/2008-05/msg00246.html

BTW I sometimes found it difficult myself that value >1< nullifies validity of
a value so I understand the ease of such bug.


Thanks,
Jan


  reply	other threads:[~2010-07-02 21:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 19:42 Tom Tromey
2010-07-02 21:07 ` Jan Kratochvil [this message]
2010-07-02 21:22   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100702210728.GA631@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox