From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PR Python/12212
Date: Tue, 16 Nov 2010 17:47:00 -0000 [thread overview]
Message-ID: <m3oc9p40ve.fsf@redhat.com> (raw)
In-Reply-To: <m3d3q5i37l.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 16 Nov 2010 10:32:46 -0700")
Tom Tromey <tromey@redhat.com> writes:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> This patches fixes a case where the API can request the currently
> Phil> selected thread from GDB when no inferior is loaded. This triggers an
> Phil> error via assert. Handle it in Python code instead.
>
> This changes gdb.selected_thread to throw an exception if there is no
> thread. However, this is wrong -- the function is documented to return
> None in this case.
Oops I did not notice that the documentation. In that case the only
change is to py-inferior.c, and I can delete the changes to
py-infthread.c. Do you want me to generate a new patch, or should I
just go ahead check that change in?
Cheers,
Phil
next prev parent reply other threads:[~2010-11-16 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 10:51 Phil Muldoon
2010-11-16 18:40 ` Tom Tromey
2010-11-16 17:47 ` Phil Muldoon [this message]
2010-11-16 19:01 ` Tom Tromey
2010-11-16 20:17 ` Phil Muldoon
2010-11-16 21:27 ` Tom Tromey
2010-11-23 13:35 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3oc9p40ve.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox