From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76448-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29668 invoked by alias); 16 Nov 2010 17:47:12 -0000
Received: (qmail 29640 invoked by uid 22791); 16 Nov 2010 17:47:10 -0000
X-SWARE-Spam-Status: No, hits=-5.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Nov 2010 17:47:04 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAGHl3uw032367	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 16 Nov 2010 12:47:03 -0500
Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAGHl1QX019773;	Tue, 16 Nov 2010 12:47:02 -0500
From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PR Python/12212
References: <m37hgdmti0.fsf@redhat.com> <m3d3q5i37l.fsf@fleche.redhat.com>
Reply-to: pmuldoon@redhat.com
X-URL: http://www.redhat.com
Date: Tue, 16 Nov 2010 17:47:00 -0000
In-Reply-To: <m3d3q5i37l.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue,	16 Nov 2010 10:32:46 -0700")
Message-ID: <m3oc9p40ve.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00205.txt.bz2

Tom Tromey <tromey@redhat.com> writes:

>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> This patches fixes a case where the API can request the currently
> Phil> selected thread from GDB when no inferior is loaded.  This triggers an
> Phil> error via assert.  Handle it in Python code instead.
>
> This changes gdb.selected_thread to throw an exception if there is no
> thread.  However, this is wrong -- the function is documented to return
> None in this case.


Oops I did not notice that the documentation.  In that case the only
change is to py-inferior.c, and I can delete the changes to
py-infthread.c.  Do you want me to generate a new patch, or should I
just go ahead check that change in?

Cheers,

Phil