From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: check for over- and under-flow in decode_locdesc
Date: Fri, 19 Nov 2010 16:32:00 -0000 [thread overview]
Message-ID: <m3oc9lb7fd.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101119062458.GA3514@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri, 19 Nov 2010 07:24:58 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> On Thu, 18 Nov 2010 22:24:27 +0100, Tom Tromey wrote:
>> + if (stacki >= sizeof (stack) / sizeof (*stack) - 1)
Jan> I would prefer ARRAY_SIZE here (but sizeof()/sizeof() is also
Jan> common in GDB).
I'll commit it shortly with this change.
Jan> I will check in the testcase later and if OK.
I am curious to know how you made this.
Did you just write it by hand?
Tom
next prev parent reply other threads:[~2010-11-19 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 21:24 Tom Tromey
2010-11-19 6:25 ` Jan Kratochvil
2010-11-19 16:32 ` Tom Tromey [this message]
2010-11-19 16:37 ` Jan Kratochvil
2010-11-19 16:34 ` Tom Tromey
2010-11-20 1:53 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3oc9lb7fd.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox