From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76501-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8510 invoked by alias); 19 Nov 2010 16:32:51 -0000
Received: (qmail 8501 invoked by uid 22791); 19 Nov 2010 16:32:50 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Nov 2010 16:32:45 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAJGWgTk029407	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 19 Nov 2010 11:32:42 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oAJGWgjn017137;	Fri, 19 Nov 2010 11:32:42 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oAJGWfeX011903;	Fri, 19 Nov 2010 11:32:41 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id 0304C3784F6; Fri, 19 Nov 2010 09:32:39 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: check for over- and under-flow in decode_locdesc
References: <m362vucol0.fsf@fleche.redhat.com>	<20101119062458.GA3514@host0.dyn.jankratochvil.net>
Date: Fri, 19 Nov 2010 16:32:00 -0000
In-Reply-To: <20101119062458.GA3514@host0.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Fri, 19 Nov 2010 07:24:58 +0100")
Message-ID: <m3oc9lb7fd.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00258.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> On Thu, 18 Nov 2010 22:24:27 +0100, Tom Tromey wrote:
>> +      if (stacki >= sizeof (stack) / sizeof (*stack) - 1)

Jan> I would prefer ARRAY_SIZE here (but sizeof()/sizeof() is also
Jan> common in GDB).

I'll commit it shortly with this change.

Jan> I will check in the testcase later and if OK.

I am curious to know how you made this.
Did you just write it by hand?

Tom