Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] gdb.base/jit.exp: Add testcase name to log message
@ 2011-09-26  5:52 Edjunior Barbosa Machado
  2011-10-03 19:28 ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Edjunior Barbosa Machado @ 2011-09-26  5:52 UTC (permalink / raw)
  To: gdb-patches; +Cc: Edjunior Barbosa Machado

Hi,

this minor patch just adds the testcase name to the log message, following the
common pattern from the others testcases. Ok to commit?

--
Edjunior

2011-09-26  Edjunior Machado  <emachado@linux.vnet.ibm.com>

	gdb/testsuite/
	* gdb.base/jit.exp: Add testcase name to log message

---
 gdb/testsuite/gdb.base/jit.exp |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.base/jit.exp b/gdb/testsuite/gdb.base/jit.exp
index a6a8cc0..6c4c424 100644
--- a/gdb/testsuite/gdb.base/jit.exp
+++ b/gdb/testsuite/gdb.base/jit.exp
@@ -59,7 +59,7 @@ proc one_jit_test {count match_str} {
     global verbose testfile solib_binfile_target solib_binfile_test_msg pf_prefix
 
     set old_pf_prefix $pf_prefix
-    set pf_prefix "one_jit_test-$count"
+    lappend pf_prefix "one_jit_test-$count:"
 
     clean_restart $testfile
 
@@ -97,7 +97,7 @@ proc one_jit_test {count match_str} {
     gdb_continue_to_breakpoint "break here 2"
     # All jit librares must have been unregistered
     gdb_test "info function jit_function" \
-	"All functions matching regular expression \"jit_function\":" \
+	"All functions matching regular expression \"jit_function\":" 
     set pf_prefix $old_pf_prefix
 }
 
-- 
1.6.0.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb.base/jit.exp: Add testcase name to log message
  2011-09-26  5:52 [PATCH] gdb.base/jit.exp: Add testcase name to log message Edjunior Barbosa Machado
@ 2011-10-03 19:28 ` Tom Tromey
  2011-10-03 20:21   ` Edjunior Barbosa Machado
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2011-10-03 19:28 UTC (permalink / raw)
  To: Edjunior Barbosa Machado; +Cc: gdb-patches

>>>>> "Edjunior" == Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes:

Edjunior> 2011-09-26  Edjunior Machado  <emachado@linux.vnet.ibm.com>
Edjunior> 	gdb/testsuite/
Edjunior> 	* gdb.base/jit.exp: Add testcase name to log message

This is ok.  Thanks.

Edjunior>      gdb_test "info function jit_function" \
Edjunior> -	"All functions matching regular expression \"jit_function\":" \
Edjunior> +	"All functions matching regular expression \"jit_function\":" 
Edjunior>      set pf_prefix $old_pf_prefix
Edjunior>  }

FWIW this hunk looks like an obvious bug fix.

Tom


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb.base/jit.exp: Add testcase name to log message
  2011-10-03 19:28 ` Tom Tromey
@ 2011-10-03 20:21   ` Edjunior Barbosa Machado
  0 siblings, 0 replies; 3+ messages in thread
From: Edjunior Barbosa Machado @ 2011-10-03 20:21 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On 10/03/2011 04:27 PM, Tom Tromey wrote:
>>>>>> "Edjunior" == Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes:
> 
> Edjunior> 2011-09-26  Edjunior Machado  <emachado@linux.vnet.ibm.com>
> Edjunior> 	gdb/testsuite/
> Edjunior> 	* gdb.base/jit.exp: Add testcase name to log message
> 
> This is ok.  Thanks.

Thanks, committed:

http://sourceware.org/ml/gdb-cvs/2011-10/msg00011.html

-- 
Edjunior


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-03 20:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-26  5:52 [PATCH] gdb.base/jit.exp: Add testcase name to log message Edjunior Barbosa Machado
2011-10-03 19:28 ` Tom Tromey
2011-10-03 20:21   ` Edjunior Barbosa Machado

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox