From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Avoid computing fullname if unused.
Date: Mon, 07 Nov 2011 14:49:00 -0000 [thread overview]
Message-ID: <m3obwong3a.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20111107063715.554F5246194@ruffy.mtv.corp.google.com> (Doug Evans's message of "Sun, 6 Nov 2011 22:37:15 -0800 (PST)")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> 2011-11-06 Doug Evans <dje@google.com>
Doug> * dwarf2read.c (dw2_map_symbol_filenames): New parameter
Doug> `need_fullname'.
Doug> * psymtab.c (map_symbol_filenames_psymtab): Ditto.
Doug> (map_partial_symbol_filenames): Ditto. All callers updated.
Doug> * psymtab.h (map_partial_symbol_filenames): Update prototype.
Doug> * symfile.h (struct quick_symbol_functions, map_symbol_filenames): New
Doug> parameter need_fullname.
Seems reasonable to me.
Ideally these could be computed lazily, but that is a bit of a pain in C.
Doug> + map_partial_symbol_filenames (print_partial_file_name, NULL,
Doug> + TRUE /*need_fullname*/);
I don't think TRUE and FALSE are really part of the gdb style.
gdb tends to just use 0/1 for this.
I'd like us to follow gcc and use 'bool', 'true', and 'false' -- but not
these all-caps spellings.
Tom
next prev parent reply other threads:[~2011-11-07 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 6:37 Doug Evans
2011-11-07 14:49 ` Tom Tromey [this message]
2011-11-11 0:46 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3obwong3a.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox