From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8572 invoked by alias); 7 Nov 2011 14:49:04 -0000 Received: (qmail 8563 invoked by uid 22791); 7 Nov 2011 14:49:02 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 14:48:44 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA7EmhZa015028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Nov 2011 09:48:43 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA7EmhOP004634; Mon, 7 Nov 2011 09:48:43 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA7EmfWM002917; Mon, 7 Nov 2011 09:48:42 -0500 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [patch] Avoid computing fullname if unused. References: <20111107063715.554F5246194@ruffy.mtv.corp.google.com> Date: Mon, 07 Nov 2011 14:49:00 -0000 In-Reply-To: <20111107063715.554F5246194@ruffy.mtv.corp.google.com> (Doug Evans's message of "Sun, 6 Nov 2011 22:37:15 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00149.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> 2011-11-06 Doug Evans Doug> * dwarf2read.c (dw2_map_symbol_filenames): New parameter Doug> `need_fullname'. Doug> * psymtab.c (map_symbol_filenames_psymtab): Ditto. Doug> (map_partial_symbol_filenames): Ditto. All callers updated. Doug> * psymtab.h (map_partial_symbol_filenames): Update prototype. Doug> * symfile.h (struct quick_symbol_functions, map_symbol_filenames): New Doug> parameter need_fullname. Seems reasonable to me. Ideally these could be computed lazily, but that is a bit of a pain in C. Doug> + map_partial_symbol_filenames (print_partial_file_name, NULL, Doug> + TRUE /*need_fullname*/); I don't think TRUE and FALSE are really part of the gdb style. gdb tends to just use 0/1 for this. I'd like us to follow gcc and use 'bool', 'true', and 'false' -- but not these all-caps spellings. Tom